upgrade to Scala 2.12 #4574
upgrade to Scala 2.12 #4574
Conversation
|
isn't this PR dropping the support of 2.11 instead of support both 2.11 and 2.12? |
i made sure to select libraries and syntax that work well for both scala 2.11 and 2.12. maven doesnt support building artifacts for two scala versions. but artifacts for scala 2.11 can be build and tested by making a few very small changes to the pom file. this could be automated in a bash script if desired. i think the same probably applies to the automated testing infrastructure, although it will be a little more work. for example |
it's fine, we can safely just support 2.12 as we are moving to the next 1.0 release |
|
What is the time frame for a release containing this? |
|
@dre-hh FYI, we are working to compile XGBoost with Scala 2.12. |
|
as 2.12 would be our major goal, I don't think we still need to change the artifact name, what do you think @koertkuipers |
i prefer to change artifact name to have scala version in it (as ugly as it is...) folks might want to cross-build for 2.11 and 2.12 (or for 2.12 and 2.13 at some point for spark 3). for them life will be easier if you have scala version in artifact name. |
|
make sense |
|
merged, thanks |
hello!
spark 2.4 will be last spark release to support scala 2.11 and is also available for scala 2.12
flink 1.7 is available for scala 2.11 and scala 2.12. i am not familiar enough with flink or its community to say when they will drop scala 2.11
this pullrequest builds the jvm libs using scala 2.12. to make the switch i had to change java version to 1.8 (required for scala 2.12) and upgrade flink and akka.
to be able to publish artifacts for both scala 2.11 and 2.12 (scala is not compatible across minor versions) i modified the artifacts to have scala version in the name. its not pretty :( but it seems to be the convention.
to publish artifacts for scala 2.11 one just has to make a few small modifications to pom files. this can probably easily be automated with a bash script. e.g.
jvm-packages/dev/change_scala_version.sh. i am not aware of an approach with maven where both scala 2.11 and scala 2.12 artifacs can be created more elegantly.